Remove deprecated Opts from limayaml #4176
Draft
+41
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a bit early to do now, and it is not ready... Just thought I would show the long-term plan. It also removes a bit of "stutter" from the previous classes, that assumed there were 2-3 global drivers. QEMUOpts -> pkg/driver/qemu.Opts VZOpts -> pkg/driver/vz.Opts |
Also remove the knowledge of the yaml structures from the internal VM class, and make it use Config. Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
vmopts-driver
branch
from
c9db1df to
f6cfe0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove the knowledge of the yaml structures
from the internal VM class, and make it use Config.
Follow-up from: