refactor(proxy/http): a concrete orig_proto error
#3901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
force-pushed
the
kate/proxy-http.concrete-type-for-downgrade-errors
branch
4 times, most recently
from
4c14378 to
c50c590
Compare
olix0r
approved these changes
May 12, 2025
Base automatically changed from
kate/proxy-http.refactor-http1-client-service
to
main
May 12, 2025 19:38
this commit introduces a concrete error type for the `orig_proto` upgrade layer. this layer is used by the proxy's http client to transparently upgrade outbound http/1 traffic to http/2. rather than boxing errors, we define a concrete error type to facilitate inspecting errors in the future. for now, the top-level http client continues to box errors thrown by the "orig_proto" upgrade client. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/proxy-http.concrete-type-for-downgrade-errors
branch
from
c50c590 to
7382b65
Compare
|
force pushed, now that #3894 has merged. ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit introduces a concrete error type for the
orig_protoupgrade layer.this layer is used by the proxy's http client to transparently upgrade outbound http/1 traffic to http/2. rather than boxing errors, we define a concrete error type to facilitate inspecting errors in the future.
for now, the top-level http client continues to box errors thrown by the "orig_proto" upgrade client.
nb: this is based upon #3894.