nit(app): consolidate impl Config blocks
#3919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a trivial, cosmetic change. `Config` has two consecutive `impl` blocks in the `linkerd-app` library. these do not include distinct generics or trait bounds, so the methods contained therein do not need to live in two distinct `impl` blocks. this commit consolidates these blocks. while we are performing this change, we add two `=== impl T ===` banners, which are used throughout the project as greppable strings to find methods and trait implementations for a given type. Signed-off-by: katelyn martin <[email protected]>
sfleen
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a trivial, cosmetic change.
Confighas two consecutiveimplblocks in thelinkerd-applibrary. these do not include distinct generics or trait bounds, so the methods contained therein do not need to live in two distinctimplblocks.this commit consolidates these blocks.
while we are performing this change, we add two
=== impl T ===banners, which are used throughout the project as greppable strings to find methods and trait implementations for a given type.