check for reallocarray before using it #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in kplot there is a runtime check for reallocarray which actually wont
work in cross compile mode, luckily it does check for HAVE_REALLOCARRAY
before usng the results of runtime check. So here add a configure time
check for presense of reallocarray
Fixes
TOPDIR/build/tmp/work/core2-32-yoe-linux/libegt/0.8-r0/recipe-sysroot/usr/include/stdlib.h:559:14: error: exception specification in declaration does not match previous declaration
extern void *reallocarray (void *__ptr, size_t __nmemb, size_t __size)
^
../external/kplot/compat.h:24:7: note: previous declaration is here
void *reallocarray(void *optr, size_t nmemb, size_t size);
^
Signed-off-by: Khem Raj <[email protected]>
kraj
force-pushed
the
master
branch
2 times, most recently
from
6f0aafe to
7065fd9
Compare
|
kplot was removed from EGT as part of the move to plplot. So, this pull request is no longer valid. If you must maintain an older version of EGT with this patch, it should unfortunately be handled in the build system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in kplot there is a runtime check for reallocarray which actually wont
work in cross compile mode, luckily it does check for HAVE_REALLOCARRAY
before usng the results of runtime check. So here add a configure time
check for presense of reallocarray
Fixes
TOPDIR/build/tmp/work/core2-32-yoe-linux/libegt/0.8-r0/recipe-sysroot/usr/include/stdlib.h:559:14: error: exception specification in declaration does not match previous declaration
extern void *reallocarray (void *__ptr, size_t __nmemb, size_t __size)
^
../external/kplot/compat.h:24:7: note: previous declaration is here
void *reallocarray(void *optr, size_t nmemb, size_t size);
^
Upstream-Status: Pending
Signed-off-by: Khem Raj [email protected]