Extracted mime instantiation to outer scope #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code is called later on without require function available, the code still works.
|
@afan1 did the tests run for you ok locally? |
|
@afan1 just updated the Dockerfile so you should be able to run the tests |
|
sorry...didnt see the change was so tiny :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...so that even if base64_encode is called later on without require function available, the code still works.
This is for the case that if we instantiate a websocket client in a pseudo sandboxed environment where the require function has been set to nil (_G.require = nil) we can still use the websocket client without it crashing.