feat(ai): enable AI orchestrator discovery #3004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit incorporates the AIServiceRegistry contract address, superseding the conventional ServiceRegistry contract address. This strategic alteration streamlines the discovery process of AI Orchestrators within the AI Subnet, thereby bolstering network accessibility and interaction. While this approach serves as a swift workaround to enable the feature without extensive code modification, it's important to note that it may disrupt the existing transcoding discovery mechanism. We have to fix this if we want to merge the two networks in the future.
|
Related to livepeer/protocol#642. See my comments in livepeer/protocol#642 (comment). |
This commit ensures that people are aware that they have to interact with the `AIServiceRegistry` using their main Orch wallet.
yondonfu
reviewed
Apr 15, 2024
This commit ensure that the hardcoded `AIServiceRegistry` contract doesn't break the go-livepeer binary on local devnets or testnets.
2 tasks
This was referenced May 15, 2024
Merged
5 tasks
This was referenced Jul 1, 2024
Merged
This was referenced Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit incorporates the AIServiceRegistry contract address, superseding the conventional ServiceRegistry contract address. This strategic alteration streamlines the discovery process of AI Orchestrators within the AI Subnet, thereby bolstering network accessibility and interaction. While this approach serves as a swift workaround to enable the feature without extensive code modification, it's important to note that it may disrupt the existing transcoding discovery mechanism. We have to fix this if we want to merge the two networks in the future.
Warning
Do not merge into the main branch this pull request breaks the discovery of the regular transcoding network.
What does this pull request do? Explain your changes. (required)
This pull request implements https://linear.app/livepeer-ai-spe/issue/LIV-90/design-and-implement-solution-for-advertising-separate-service-uri-for so that AI subnet orchestrators can be found by the AI gateway.
Specific updates (required)
serviceRegistryAddrwas changed to a newly deployed AIServiceRegistroyProxy contract.How did you test each of these updates (required)
I checked if the service URIs of the orchestrators were to the values stored in the AIServiceRegistroyProxy contract. I have yet to test if an on-chain broadcaster can still send jobs.
Does this pull request close any open issues?
https://linear.app/livepeer-ai-spe/issue/LIV-90/design-and-implement-solution-for-advertising-separate-service-uri-for
Checklist:
makeruns successfully./test.shpass