Skip to content

[4.2] Add support for polyfill packages #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
llaville opened this issue Mar 15, 2022 · 14 comments
Closed

[4.2] Add support for polyfill packages #120

llaville opened this issue Mar 15, 2022 · 14 comments
Assignees
@llaville
Labels
enhancement

Comments

@llaville
Copy link
Owner

llaville commented Mar 15, 2022 •
edited
Loading

New Feature request

Summary

Add support for PHP polyfills.

Description

In context of feature request llaville/php-compatinfo#237 for PHP_CompatInfo, I've introduced with commit c5ce8ac the new command db:polyfill that is able to handle compatible Composer polyfill packages like :
@llaville llaville self-assigned this Mar 15, 2022
@llaville
Copy link
Owner Author

See discussion #121 for details on how to add support for a new polyfill package

llaville added a commit that referenced this issue Mar 15, 2022
@llaville
add symfony/polyfill-php81 polyfill support in context of feature req…
c59fca4 
…uest #120
@llaville
Copy link
Owner Author

db_polyfill_command

llaville added a commit that referenced this issue Mar 15, 2022
@llaville
add symfony/polyfill-php80 polyfill support in context of feature req…
9bbf878 
…uest #120
@llaville
Copy link
Owner Author

db_polyfill_php80

llaville added a commit that referenced this issue Mar 15, 2022
@llaville
add symfony/polyfill-php74 polyfill support in context of feature req…
3f45000 
…uest #120
@llaville
Copy link
Owner Author

db_polyfill_php74

llaville added a commit that referenced this issue Mar 15, 2022
@llaville
add symfony/polyfill-php73 polyfill support in context of feature req…
0f72845 
…uest #120
@llaville
Copy link
Owner Author

db_polyfill_php73

@llaville
Copy link
Owner Author

I'm happy to see that this new feature will allow to improve again database contents, because it will help to find what definition are not yet declared.

When I've tried to analyse symfony/polyfill-php72 I got errors, confirmed by PHP_CompatInfo conditions report

polyfill-php72_condition-analysis-issue

@llaville
Copy link
Owner Author

Previous elements of PHP 7.2 were fixed with commits : bd33596, 1c0058d and 79f78cf

llaville added a commit that referenced this issue Mar 15, 2022
@llaville
add symfony/polyfill-php72 polyfill support in context of feature req…
021efae 
…uest #120
@llaville
Copy link
Owner Author

db_polyfill_php72

@llaville
Copy link
Owner Author

Once again, I'm happy to see that this new feature will allow to improve again database contents, because it will help to find what definition are not yet declared.

When I've tried to analyse symfony/polyfill-iconv I got errors, confirmed by PHP_CompatInfo conditions report

polyfill-iconv

llaville added a commit to llaville/php-compatinfo that referenced this issue Mar 16, 2022
@llaville
do not cache result in context of llaville/php-compatinfo-db#120 (com…
722de98 
…ment)
@llaville
Copy link
Owner Author

Issue above was fixed with commit 722de98 in PHP CompatInfo project

llaville added a commit that referenced this issue Mar 17, 2022
@llaville
add symfony/polyfill-iconv polyfill support in context of feature req…
1747f30 
…uest #120
@llaville
Copy link
Owner Author

db_polyfill_iconv--grab-all

Read also discussion #121 (comment) related to debug mode

@llaville
Copy link
Owner Author

Commit e292349 added support to polyfill symfony/polyfill-mbstring package

@llaville
Copy link
Owner Author

polyfill-mbstring

llaville added a commit that referenced this issue Mar 18, 2022
@llaville
add symfony/polyfill-ctype polyfill support in context of feature req…
bb20cda 
…uest #120
@llaville
Copy link
Owner Author

polyfill-ctype

llaville added a commit that referenced this issue Mar 19, 2022
@llaville
Merge branch polyfill to 4.x (#122)
0f8b383 
* add symfony/polyfill-php81 polyfill support in context of feature request #120

* add symfony/polyfill-php80 polyfill support in context of feature request #120

* add symfony/polyfill-php74 polyfill support in context of feature request #120

* add symfony/polyfill-php73 polyfill support in context of feature request #120

* add float limit constants missing (see php/php-src@100650b)

* add sapi_windows_vt100_support missing function from standard extension

* add os family constant missing (see php/php-src@bb059fe)

* add symfony/polyfill-php72 polyfill support in context of feature request #120

* improve db:polyfill command accordingly to #121 (comment)

* add symfony/polyfill-iconv polyfill support in context of feature request #120

* add symfony/polyfill-mbstring polyfill support in context of feature request #120

* add symfony/polyfill-ctype polyfill support in context of feature request #120
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llaville llaville

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@llaville