Skip to content

[clang] Restrict the use of scalar types in vector builtins #119423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 29, 2025
Merged

[clang] Restrict the use of scalar types in vector builtins #119423

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3f007d7
[clang] Fix sub-integer __builtin_elementwise_(add|sub)_sat
frasercrmck Dec 10, 2024
4d39f93
fix popcount/bitreverse
frasercrmck Dec 11, 2024
479f384
wip: prevent any type mixing
frasercrmck Dec 18, 2024
ad8ccba
update tests
frasercrmck Jan 6, 2025
80a8399
update docs
frasercrmck Jan 6, 2025
453460f
update docs: newline
frasercrmck Jan 6, 2025
f009991
fp conversions
frasercrmck Jan 7, 2025
9d7e79d
forbid mixed enums
frasercrmck Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix popcount/bitreverse
  • Loading branch information
@frasercrmck
frasercrmck committed Jan 6, 2025
commit 4d39f93bedd6c25de17a1a168c727f5383701740
21 changes: 19 additions & 2 deletions clang/lib/Sema/SemaChecking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2828,11 +2828,28 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID,
break;
case Builtin::BI__builtin_elementwise_popcount:
case Builtin::BI__builtin_elementwise_bitreverse: {
if (PrepareBuiltinElementwiseMathOneArgCall(TheCall))
if (checkArgCount(TheCall, 1))
return ExprError();

const Expr *Arg = TheCall->getArg(0);
Expr *Arg = TheCall->getArg(0);
QualType ArgTy = Arg->getType();

// If the argument is a promotable integer type, do not perform the usual
// conversions - we must keep the operation at the correct bitwidth.
if (Context.isPromotableIntegerType(ArgTy)) {
// Convert the argument to an r-value - avoid the usual conversions.
ExprResult ResLHS = DefaultFunctionArrayLvalueConversion(Arg);
if (ResLHS.isInvalid())
return ExprError();
Arg = ResLHS.get();
TheCall->setArg(0, Arg);
TheCall->setType(Arg->getType());
break;
}

if (PrepareBuiltinElementwiseMathOneArgCall(TheCall))
return ExprError();

QualType EltTy = ArgTy;

if (auto *VecTy = EltTy->getAs<VectorType>())
Expand Down
46 changes: 38 additions & 8 deletions clang/test/CodeGen/builtins-elementwise-math.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,8 @@ void test_builtin_elementwise_min(float f1, float f2, double d1, double d2,

void test_builtin_elementwise_bitreverse(si8 vi1, si8 vi2,
long long int i1, long long int i2, short si,
_BitInt(31) bi1, _BitInt(31) bi2) {
_BitInt(31) bi1, _BitInt(31) bi2,
char ci) {


// CHECK: [[I1:%.+]] = load i64, ptr %i1.addr, align 8
Expand Down Expand Up @@ -541,10 +542,24 @@ void test_builtin_elementwise_bitreverse(si8 vi1, si8 vi2,
b = __builtin_elementwise_bitreverse(-10);

// CHECK: [[SI:%.+]] = load i16, ptr %si.addr, align 2
// CHECK-NEXT: [[SI_EXT:%.+]] = sext i16 [[SI]] to i32
// CHECK-NEXT: [[RES:%.+]] = call i32 @llvm.bitreverse.i32(i32 [[SI_EXT]])
// CHECK-NEXT: = trunc i32 [[RES]] to i16
// CHECK-NEXT: [[RES:%.+]] = call i16 @llvm.bitreverse.i16(i16 [[SI]])
si = __builtin_elementwise_bitreverse(si);

// CHECK: store i16 28671, ptr %si.addr, align 2
si = __builtin_elementwise_bitreverse((short)-10);

// CHECK: store i16 28671, ptr %si.addr, align 2
si = __builtin_elementwise_bitreverse((unsigned short)-10);

// CHECK: [[CI:%.+]] = load i8, ptr %ci.addr, align 1
// CHECK-NEXT: [[RES:%.+]] = call i8 @llvm.bitreverse.i8(i8 [[CI]])
ci = __builtin_elementwise_bitreverse(ci);

// CHECK: store i8 111, ptr %ci.addr, align 1
ci = __builtin_elementwise_bitreverse((unsigned char)-10);

// CHECK: store i8 111, ptr %ci.addr, align 1
ci = __builtin_elementwise_bitreverse((char)-10);
}

void test_builtin_elementwise_ceil(float f1, float f2, double d1, double d2,
Expand Down Expand Up @@ -762,7 +777,8 @@ void test_builtin_elementwise_log2(float f1, float f2, double d1, double d2,

void test_builtin_elementwise_popcount(si8 vi1, si8 vi2, long long int i1,
long long int i2, short si,
_BitInt(31) bi1, _BitInt(31) bi2) {
_BitInt(31) bi1, _BitInt(31) bi2,
char ci) {
// CHECK: [[I1:%.+]] = load i64, ptr %i1.addr, align 8
// CHECK-NEXT: call i64 @llvm.ctpop.i64(i64 [[I1]])
i2 = __builtin_elementwise_popcount(i1);
Expand All @@ -789,10 +805,24 @@ void test_builtin_elementwise_popcount(si8 vi1, si8 vi2, long long int i1,
b = __builtin_elementwise_popcount(-10);

// CHECK: [[SI:%.+]] = load i16, ptr %si.addr, align 2
// CHECK-NEXT: [[SI_EXT:%.+]] = sext i16 [[SI]] to i32
// CHECK-NEXT: [[RES:%.+]] = call i32 @llvm.ctpop.i32(i32 [[SI_EXT]])
// CHECK-NEXT: = trunc i32 [[RES]] to i16
// CHECK-NEXT: [[RES:%.+]] = call i16 @llvm.ctpop.i16(i16 [[SI]])
si = __builtin_elementwise_popcount(si);

// CHECK: store i16 3, ptr %si.addr, align 2
si = __builtin_elementwise_popcount((unsigned short)32771);

// CHECK: store i16 3, ptr %si.addr, align 2
si = __builtin_elementwise_popcount((short)32771);

// CHECK: [[CI:%.+]] = load i8, ptr %ci.addr, align 1
// CHECK-NEXT: [[RES:%.+]] = call i8 @llvm.ctpop.i8(i8 [[CI]])
ci = __builtin_elementwise_popcount(ci);

// CHECK: store i8 2, ptr %ci.addr, align 1
ci = __builtin_elementwise_popcount((unsigned char)192);

// CHECK: store i8 2, ptr %ci.addr, align 1
ci = __builtin_elementwise_popcount((char)192);
}

void test_builtin_elementwise_fmod(float f1, float f2, double d1, double d2,
Expand Down