Skip to content

Conversation

dsmiley
Copy link
Contributor

@dsmiley dsmiley commented Nov 20, 2020

Each commit here addresses a specific matter... with maybe a slight deviation once or twice. Don't view all files at once; go commit-by-commit. Admittedly not all this is "necessary", but it's in line with the language upgrade -- take advantage of the language. Justin, you may want to review the "Geom" in particular.

Signed-off-by: David Smiley <[email protected]>
And adjust javadoc lint to not complain about missing javadocs
And adjust javadoc lint to not complain about missing javadocs
new ArrayList<Shape> with new ArrayList<>
Also removed one "dead store".
And suppress deprecation warnings for now.
@dsmiley dsmiley requested a review from jdeolive November 20, 2020 06:04
@codecov-io
Copy link

codecov-io commented Nov 21, 2020

Codecov Report

Merging #197 (5d74f96) into master (052cd12) will decrease coverage by 0.03%.
The diff coverage is 76.47%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #197      +/-   ##
============================================
- Coverage     75.95%   75.92%   -0.04%     
- Complexity     1111     1112       +1     
============================================
  Files            57       59       +2     
  Lines          3826     3825       -1     
  Branches        775      775              
============================================
- Hits           2906     2904       -2     
- Misses          642      644       +2     
+ Partials        278      277       -1     
Impacted Files Coverage Δ Complexity Δ
...locationtech/spatial4j/context/SpatialContext.java 76.56% <ø> (ø) 28.00 <0.00> (ø)
...locationtech/spatial4j/distance/DistanceUtils.java 69.75% <ø> (ø) 50.00 <0.00> (ø)
.../java/org/locationtech/spatial4j/io/WKTReader.java 87.70% <ø> (ø) 52.00 <0.00> (ø)
...tech/spatial4j/io/jts/JtsWKTReaderShapeParser.java 75.75% <ø> (ø) 7.00 <0.00> (ø)
...n/java/org/locationtech/spatial4j/shape/Point.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../locationtech/spatial4j/shape/ShapeCollection.java 48.78% <0.00%> (ø) 22.00 <0.00> (ø)
...ocationtech/spatial4j/shape/impl/BufferedLine.java 77.55% <ø> (ø) 29.00 <0.00> (ø)
...iontech/spatial4j/shape/impl/ShapeFactoryImpl.java 81.81% <ø> (+0.49%) 39.00 <0.00> (ø)
...ationtech/spatial4j/shape/jts/JtsShapeFactory.java 93.06% <ø> (+0.45%) 58.00 <0.00> (ø)
...org/locationtech/spatial4j/shape/ShapeFactory.java 50.00% <50.00%> (ø) 1.00 <1.00> (?)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 052cd12...5d74f96. Read the comment docs.

Copy link
Contributor

@jdeolive jdeolive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me David, nice work!

@dsmiley dsmiley merged commit 1f6e204 into locationtech:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants