tests: checks if column is discovered and mapped correctly #422
Conversation
| }, | ||
| }; | ||
| Demo = db.createModel(demo_schema.name, demo_schema.properties, demo_schema.options); | ||
| Demo.destroyAll(done); |
There was a problem hiding this comment.
Maybe add a comment. why create a model and then destroy all?
There was a problem hiding this comment.
db.createModel is to create model so that we can do CRUD operations. .destroyAll is to delete all instances. They are basic steps and used in many test files.
test/postgresql.discover.test.js
Outdated
| console.error(err); | ||
| done(err); | ||
| } else { | ||
| models.forEach(function(m) { |
There was a problem hiding this comment.
Why loop if there is only 1 model?
There was a problem hiding this comment.
Match with other tests.
There was a problem hiding this comment.
I think it makes sense to not loop if it's only one model, even if it's inconsistent with the other tests, but it's not a big deal.
test/postgresql.discover.test.js
Outdated
| console.error(err); | ||
| done(err); | ||
| } else { | ||
| models.forEach(function(m) { |
There was a problem hiding this comment.
I think it makes sense to not loop if it's only one model, even if it's inconsistent with the other tests, but it's not a big deal.
|
@slnode test please |
add a test case for Postgres for changes made in loopbackio/loopback-connector#171
demoIdChecklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machine