Skip to content

Combined dependabot and docklib PRs #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 8, 2021
Merged

Combined dependabot and docklib PRs #30

merged 17 commits into from
Jul 8, 2021

Conversation

natewalck
Copy link
Member

This should be a bundle of all currently open PRs so it is easier to test the python compilation.

@natewalck natewalck requested a review from erikng July 8, 2021 14:25
@erikng
Copy link
Member

erikng commented Jul 8, 2021

Check is failing :/

@natewalck
Copy link
Member Author

This should make it more obvious which .so is not universal.

@natewalck
Copy link
Member Author

Woot:

Shared objects do not match, resulting in a non-universal Python framework.
Total shared objects found: 175
Universal shared objects found: 174
./recommended/payload//Library/ManagedFrameworks/Python/Python3.framework/Versions/Current/lib/python3.9/site-packages/yaml/_yaml.cpython-39-darwin.so
Error: Process completed with exit code 1.

@natewalck
Copy link
Member Author

I believe this is ready for review.

@natewalck natewalck requested a review from gregneagle July 8, 2021 20:19
@natewalck natewalck self-assigned this Jul 8, 2021
@erikng erikng mentioned this pull request Jul 8, 2021
@erikng
Copy link
Member

erikng commented Jul 8, 2021

The CI is failing, but after investigating it's because of the following:

if: github.ref == 'refs/heads/main'. The p12 certs are only created if on main, so the CI partially fails due to artifacts. We shouldn't be creating a release for PRs.

@erikng
Copy link
Member

erikng commented Jul 8, 2021

Check are passing! Merging.

@erikng erikng merged commit eb1558c into main Jul 8, 2021
@erikng erikng deleted the dependabot-and-docklib branch July 8, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants