Coupon for single use can be used multiple times

[HenKun]

Preconditions and environment

• Magento version 2.4.6-p2
• Anything else that would help a developer reproduce the bug

Steps to reproduce

1. Create a cart rule with coupon usage and usage per coupon = 1
   

2. Add fixed cart as Action
   

3. Generate coupon code (used is no, used times is 0)
   

4. Open browser 1, apply coupon code an go to last checkout page
   

5. Open browser 2 (or incognito tab), apply coupon code an go to last checkout page
   

6. Place order in browser 1 and 2 simultanously (a few seconds might be ok)

7. Both orders are successfull
   
   
   

8. Control coupn code usage. It is used and "times used" is 2
   

Expected result

Coupon can only be used for one order

Actual result

Coupon can be used multiple times, if fast enough

Additional information

Related:

https://experienceleague.adobe.com/docs/commerce-knowledge-base/kb/troubleshooting/miscellaneous/coupon-code-used-more-than-once-adobe-commerce.html?lang=en
#23907
#35077

In this case, the consumer is correctly set up, so the coupon code usage is raised correctly. However, due to the queue mechanism, this is not done fast enough, so a customer can place multiple orders with the same coupon code within the time period the system needs to raise the coupon usage.

This can be exploited by customers, e.g. if coupon codes are used as simple gift cards.

Maybe it isn't a good idea to use queues in this scenario where it relies on an immediate raise of the coupon code usage?
Or a coupon code should already be blocked when it is applied to the quote.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @HenKun. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[HenKun]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @HenKun. Thank you for your request. I'm working on Magento instance for you.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-deployment-service]

Hi @HenKun, here is your Magento Instance: https://e8d12c1de32a4407b2a6fa73cee90089.instances-prod.magento-community.engineering
Admin access: https://e8d12c1de32a4407b2a6fa73cee90089.instances-prod.magento-community.engineering/admin_1332
Login: 2855f26a
Password: 70e16008704e

[HenKun]

The issue can be reproduced on generated instance.
However:

• Multiple coupon codes per rule are not generated, I had to use the specific primary coupon code.
• Fixed amount discount for whole cart isn't working at all, no discount is applied. I had to use Fixed amount discount

Nonetheless, the issue is reproduced under these conditions. Further orders (after both orders are processed) with the same coupon code fail, so it can be concluded the queue works, but is not fast enough.

[achourey]

Hi @HenKun ,

I am also facing the same issue. Please let me know if you find any solution for this issue.

Thanks in advance

[HenKun]

The problem won't be easy to solve. This needs to be done completely or at least partially synchronous. I hope Magento will care for this issue

[m2-assistant]

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Dash, here is your Magento Instance: https://e8d12c1de32a4407b2a6fa73cee90089.instances-prod.magento-community.engineering
Admin access: https://e8d12c1de32a4407b2a6fa73cee90089.instances-prod.magento-community.engineering/admin_0d42
Login: bf2913a7
Password: 1dc476ff703e

[engcom-Dash]

Hi @HenKun .Thanks for reporting and collaboration. Verified the issue on Magento 2.4-develop instance and the issue is reproducible. Please refer the below screenshots.
Cart rule :

Order from browser 1

Order from browser 2

Coupon code usage

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9649 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Dash, here is your Magento Instance: https://e8d12c1de32a4407b2a6fa73cee90089.instances-prod.magento-community.engineering
Admin access: https://e8d12c1de32a4407b2a6fa73cee90089.instances-prod.magento-community.engineering/admin_56ad
Login: ce6e0e0f
Password: b8f5909c662f

[quterorta]

@magento I am working on this

[amenk]

@engcom-Dash What is the status of this? Is a fix planned?

[amenk]

The following patch seems to work:

vendor/magento/module-sales-rule/Model/Coupon/Quote$ diff -u UpdateCouponUsages.php.orig UpdateCouponUsages.php
--- UpdateCouponUsages.php.orig 2024-05-31 11:05:21.475190656 +0200
+++ UpdateCouponUsages.php      2024-05-31 11:12:30.899470917 +0200
@@ -8,6 +8,7 @@
 namespace Magento\SalesRule\Model\Coupon\Quote;
 
 use Magento\Quote\Api\Data\CartInterface;
+use Magento\SalesRule\Model\Coupon\Usage\Processor as CouponUsageProcessor;
 use Magento\SalesRule\Model\Coupon\Usage\UpdateInfo;
 use Magento\SalesRule\Model\Coupon\Usage\UpdateInfoFactory;
 use Magento\SalesRule\Model\Service\CouponUsagePublisher;
@@ -33,10 +34,12 @@
      */
     public function __construct(
         CouponUsagePublisher $couponUsagePublisher,
-        UpdateInfoFactory $updateInfoFactory
+        UpdateInfoFactory $updateInfoFactory,
+        CouponUsageProcessor $couponUsageProcessor
     ) {
         $this->couponUsagePublisher = $couponUsagePublisher;
         $this->updateInfoFactory = $updateInfoFactory;
+        $this->couponUsageProcessor = $couponUsageProcessor;
     }
 
     /**
@@ -59,6 +62,7 @@
         $updateInfo->setCustomerId((int)$quote->getCustomerId());
         $updateInfo->setIsIncrement($increment);
 
-        $this->couponUsagePublisher->publish($updateInfo);
+        //$this->couponUsagePublisher->publish($updateInfo);
+        $this->couponUsageProcessor->process($updateInfo);
     }
 }

I guess the original intention do you this async via queue is for very high volume shops? Maybe it could be made configurable or only be queued in such cases, where the usage is not limited.

[shikharainabounteous]

any updates on this?

[jaminion]

Hello all, I was just checking on this from an internal issue and it appears they have made adjustments to make the coupon usage update synchronously. For example in the 2.4.5-p11 tagged version, they include a reference to CouponUsageProcessor in the constructor and use the updateCouponUsages() and updateCustomerRulesUsages() methods in the execute(). I'm not quite sure in what context these changes were made as they are not present in the 2.4.5-p10, but in both the 2.4.5-p11 and 2.4.5-p12 tagged versions of the file, the changes are linked to the packaging commit for that tag and no other reference.

https://github.com/magento/magento2/blob/2.4.5-p11/app/code/Magento/SalesRule/Model/Coupon/Quote/UpdateCouponUsages.php

I had been checking this issue and just seeing that it was "open" instead of looking directly at the files. Is this sufficient or are there still timing issues with the implementation?