-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Area: PerformanceIssue: needs updateAdditional information is require, waiting for responseAdditional information is require, waiting for responsePriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Progress: dev in progressReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject it
Description
This issue is automatically created based on existing pull request: #38032: Improve setup:di:compile performance by using gc_disable
Description (*)
By disabling garbage collector the code generation finishes a bit faster:
With larger apps the difference is not that significant but noticeable
2.
I also checked calling gc_collect_cycles
after each operation to save some memory, but the difference is not that significant and visible on the second screenshot.
Related Pull Requests
Fixed Issues (if relevant)
- Fixes magento/magento2#<issue_number>
Manual testing scenarios (*)
- Run setup:di:compile on different CPUs with and without changes
- Compare execution time
Questions or comments
- More tests needed on different CPUs.
- The actual result may vary per project, depending from number of plugins/factories/proxies needed to detect and generate.
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Area: PerformanceIssue: needs updateAdditional information is require, waiting for responseAdditional information is require, waiting for responsePriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Progress: dev in progressReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Triage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject itIssue related to Developer Experience and needs help with Triage to Confirm or Reject it