Skip to content

Email lang unclear #39857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 5 tasks
vandijkstef opened this issue Apr 23, 2025 · 8 comments
Open
1 of 5 tasks

Email lang unclear #39857

vandijkstef opened this issue Apr 23, 2025 · 8 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.8 Indicates original Magento version for the Issue report.

Comments

@vandijkstef
Copy link

Preconditions and environment

  • Mage version irrelevant - but still present in 2.4.8

Steps to reproduce

Send an (HTML) email towards gmail users with potential mixed language.

In our case we send out an email in Dutch language containing the word "Wit" (EN: White) which got taken as 'Wit' (EN: Wit) which got replaced with "Geestigheid" (EN: Wit)

Expected result

The email showing as intended

Actual result

Lately we have been getting some reports from customers that had weird data show up in their order confirmation (html email). All these users turned out to be Gmail users, and their software is prone to automatically translate emails. So, while I'd like to call this an 'user issue' I dove a little deeper: Mainly the email templates (email/header.html) are NOT decorated with a 'lang' attribute. Some email clients might wrongly assume the email is not in the users native language and will attempt to translate these fields, leading to confusing customers.

Additional information

I am suggesting to add a 'lang' attribute to HTML email templates, as recommended by W3 for any HTML document.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Apr 23, 2025

Hi @vandijkstef. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@hostep
Copy link
Contributor

hostep commented Apr 23, 2025

@vandijkstef: it may make sense indeed. Can you confirm if adding a lang attribute actually solves the issue? Or is that just a guess? If it's just a guess, I suggest we first try to find the proper fix and confirm it works before starting working on a fix for this.

@vandijkstef
Copy link
Author

@hostep I have not confirmed this fix yet. I can probably tell more about that next week.

Pushing towards proper standards didn't seem like a bad idea anyway and possibly there are more people with a similar issue. I couldn't find anything related.

@engcom-Delta engcom-Delta self-assigned this Apr 24, 2025
Copy link

m2-assistant bot commented Apr 24, 2025

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

engcom-Delta commented Apr 25, 2025

Hi @vandijkstef ,

Thanks for your reporting and collaboration.
We have tried to reproduce the issue in 2.4.8 instance and we are not able to reproduce the issue.Kindly refer the attached screenshot.

Steps to reproduce :

  1. Send an (HTML) email towards gmail users with potential mixed language.
    2.In our case we send out an email in Dutch language containing the word "Wit" (EN: White) which got taken as 'Wit' (EN: Wit) which got replaced with "Geestigheid" (EN: Wit)
    Before Translation

Image

After Translation

Image

Kindly recheck the issue in 2.4.8 instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Delta engcom-Delta added Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation labels Apr 25, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Apr 25, 2025
@engcom-Delta engcom-Delta added the Reported on 2.4.8 Indicates original Magento version for the Issue report. label Apr 25, 2025
@engcom-November
Copy link
Contributor

Hello @vandijkstef ,

I wanted to follow up on the issue on the above commented on a couple of weeks ago.

#39857 (comment)

Please let me know if there's anything further needed from my side.

Best regards,

@engcom-November engcom-November self-assigned this May 8, 2025
Copy link

m2-assistant bot commented May 8, 2025

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@vandijkstef
Copy link
Author

@engcom-November Sorry for the delay - 2.4.8 has some other side effects for us taking up my time.

My initial testing to put a lang attribute on the HTML-tag is NOT giving better results. It seems it's being completely ignored in gmail client.
I have moved the location of the attribute to test other locations - this goes along with my regular deployments to production so test loops take a little longer - but at least we're having real world examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.8 Indicates original Magento version for the Issue report.
Projects
Development

No branches or pull requests

4 participants