-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Refresh invalidated caches nightly #35525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @fredden. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
1 similar comment
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
I observe similar issues. When This is critical because broken cache records contains some crucial products information. We cannot clean them by saving product or any Magento logic, because of the lack of tags. It won't clean even on cache:clean action, because it has no MAGE tag too. The only way to clear it is running cache:flush. I'm not sure if flush action is a way to go though, I'll try to dig it a little bit more. |
4d4bd7d
to
fbbf3ce
Compare
@magento run all tests |
Description
When certain actions are taken in the admin, related caches are marked as invalid. Manual action is required to refresh these caches. This is often okay as the action which invalidated the cache(s) was performed by an admin user. However there are some automated actions which can invalidate caches. In this case, caches may remain in an invalidated state for long periods of time, resulting in hard-to-diagnose (unexpected) behaviour.
This pull request introduces a cronjob which will refresh all invalidated caches.
Manual testing scenarios
backend_clean_cache
cronjobbackend_refresh_invalidated_caches
crobjob (which is introduced in this pull request)Contribution checklist