Enabling Individual Editing of Shipping and Billing Addresses from the Customer Dashboard

[Franciscof-Serfe]

Description (*)

We propose an enhancement to the Magento customer dashboard's address management functionality.
Currently, when adding an address, it defaults to both billing and shipping. However, distinguishing between them becomes confusing for clients, as editing one address impacts both. This native workflow requires generating a new address to differentiate between default shipping or billing. Our enhancement streamlines this process by allowing direct individual editing of billing and shipping addresses, thereby simplifying the user experience for logged-in clients.

Video 1: "Native Magento Flow: Editing Billing and Shipping Addresses"
NativeMagento.webm

Video 2: "Improvement Proposal: Individual Editing of Billing and Shipping Addresses"
addressImprovement.webm

Manual testing scenarios (*)

1. Navigate to the customer dashboard.
2. Add a new address and verify that it defaults to both billing and shipping.
3. Edit the address and observe that both billing and shipping are affected.
4. Apply this pull request's changes and verify that individual editing of billing and shipping addresses is possible without affecting the other.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Enabling Individual Editing of Shipping and Billing Addresses from the Customer Dashboard #38678: Enabling Individual Editing of Shipping and Billing Addresses from the Customer Dashboard

[m2-assistant]

Hi @Franciscof-Serfe. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[Franciscof-Serfe]

@magento I'm working on it

[Franciscof-Serfe]

@magento create issue

[Franciscof-Serfe]

PR status update:
The branch is updated

1. Semantic version checker failure.
   Should I modify the commits message to adjust this pipe or are no actions required from my side?

2. Functional Tests falling, the changes added are not related.

Test:

• Create new user from /customer/account/create/
• Add new address. The first will be added to both billing and shipping addresses and you can edit each other individually.
  VIDEO:

testing.mp4

@ihor-sviziev , @engcom-Bravo , @engcom-Delta Can you move forward with this? Thanks.
@markshust

[engcom-Hotel]

Hello @Franciscof-Serfe,

Kindly resolve the PR conflicts so we can proceed with further processing. In the meantime, we are moving this PR to "On Hold."

Thanks

[Franciscof-Serfe]

Hi @engcom-Hotel,
This PR has been updated for merging. I apologize for the delay on my part.

The test status review is available in this comment:
#38677 (comment)

Please let me know if you need any further action from me.
Regards,
Fran

[markshust]

May be a little typo here?

[engcom-Hotel]

Hello @Franciscof-Serfe,

Thanks for the contribution!

Since this PR contains a new feature, we are marking this PR as a Feature Request and sent a mail to PO for the approval. Please allow us time, till we get the approval. In the meantime we are moving this PR On Hold.

Thanks

[Franciscof-Serfe]

Hi @engcom-Hotel ,
Just to clarify — Why is this PR considered a new feature?

I’d see something like adding profile pictures to customer accounts or address validation as a new feature. But in this case, the "Change Billing Address" and "Change Shipping Address" buttons already existed. This PR simply fixes them so they work as expected.

Thanks for reviewing and helping to clarify this.

Best regards,
Francisco

[markshust]

@engcom-Hotel I agree with @Franciscof-Serfe, this is a UI improvement so things work as expected, not a new feature.

[engcom-Hotel]

Hello @Franciscof-Serfe @markshust,

Since this PR enhances an existing feature of Magento and is not a bug, we have classified it as a feature request. The related issue has also been marked as a feature request.

This change will impact the user experience, which is why we require PO approval to proceed further.

Rest assured, we are actively working on this PR and will provide you with updates shortly.

Thanks

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[Franciscof-Serfe]

@magento run all tests

[Franciscof-Serfe]

@magento run all tests

[engcom-Hotel]

Hello @Franciscof-Serfe,

The approval on this feature request has been received from the PO. Hence moving further with the PR.

Thanks

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @Franciscof-Serfe,

Thanks for the contribution!

Please refer to the below review comments, and it seems some functional tests are failing due to this change, please fix them as well.

Also please add some automated test for this PR change.

Thanks

[engcom-Hotel]

I guess we can simplified this section as follows:

$queryParams = ['_secure' => true];

// Consolidate $defaultShipping and $defaultBilling conditions
if ($defaultShipping == 1) {
    $queryParams['default_shipping'] = 1;
}
if ($defaultBilling == 1) {
    $queryParams['default_billing'] = 1;
}

// Add 'id' parameter only if the address is not both default billing and shipping
if (!$this->getAddress()->isDefaultBilling() || !$this->getAddress()->isDefaultShipping()) {
    $queryParams['id'] = $this->getAddress()->getId();
}

// URL construction remains in a single block
$postURL = $this->_urlBuilder->getUrl(
    'customer/address/formPost',
    $queryParams
);

Just a sample code, just check the condition before implementing the same.

[engcom-Hotel]

Maintain backward compatibility for the getSaveUrl method by deprecating the old method and introducing a new one

[Franciscof-Serfe]

@magento run all tests

[engcom-Hotel]

Hello @Franciscof-Serfe,

It seems the automated tests are still failing due to the changes please check those as well and please add some automated test in accordance to the DOD.

Thanks

[Franciscof-Serfe]

Hi @engcom-Hotel ,
Sorry for the delay. I'm aware of the pending fixes.
I’ll get back to finishing this contribution as soon as I have some time available.

Regards,
Francisco