magento/magento2#38455: Fixed

[YuriyYavorskiy]

• the mistake was that the amount for non-taxes after the discount came with incorrect rounding

Description (*)

Hello, as a result of the tests, it turned out that taxes are calculated correctly and the problem is not with them. When the discount was calculated, it came with different roundings in different cases. Rounding was assigned by Magento rules

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Wrong Order total, the round is not applied to the price calculation. #38455

Manual testing scenarios (*)

To test, you need to repeat everything that was in the task, now the result of the order is correct. checked many times with different sequences

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @YuriyYavorskiy. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[YuriyYavorskiy]

• the mistake was that the amount for non-taxes after the discount came with incorrect rounding

Description (*)

Hello, as a result of the tests, it turned out that taxes are calculated correctly and the problem is not with them. When the discount was calculated, it came with different roundings in different cases. Rounding was assigned by Magento rules

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Wrong Order total, the round is not applied to the price calculation. #38455

Manual testing scenarios (*)

To test, you need to repeat everything that was in the task, now the result of the order is correct. checked many times with different sequences

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @YuriyYavorskiy,

Thanks for the contribution!

Please have a look into the failed Integration, Static, Unit tests, it seems they are failing due to the code changes, kindly fix those.

Thanks

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@engcom-Hotel review comments has been fixed. Could you please review it ?

[engcom-Bravo]

Hi @YuriyYavorskiy,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

• Install fresh Magento 2.4-develop

Steps to reproduce

• add product 1 * 3 to the cart
• add product 2 * 2 to the cart
• go to the checkout
• apply the discount and use the country for the tax to be applied
• create order

Before: ✖️ 

After: ✔️

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

[engcom-Dash]

@magento run all tests

[engcom-Dash]

@magento run Functional Tests B2B

[engcom-Dash]

One of the consistent Functional B2B test failure is a known issue and JIRA is present for the same. Other test failures are inconsistent and seems to be flaky. They are not related to this PR nor part of PR.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39687/29abe8dce3d6efc229b9eaee9fab7b64/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39687/7751779d09061327b88a7522c3048d15/Functional/allure-report-b2b/index.html#categories/8fb3a91ba5aaf9de24cc8a92edc82b5d

Known Issue: AdminDeleteCatalogPriceRuleEntityFromConfigurableProductTest ACQE-7945

Hence moving this PR in Merge In Progress.