-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Issue-39692 Widget Block Selection issue fix - If block have same identifier #39722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-39692 Widget Block Selection issue fix - If block have same identifier #39722
Conversation
All reactions
-
👍 6 reactions
…tifier and unit test case added
Hi @Mohamed-Asar. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
All reactions
Sorry, something went wrong.
@magento run all tests |
All reactions
-
👍 3 reactions
Sorry, something went wrong.
…com/Mohamed-Asar/magento2 into bug/39692-block-selection-in-widget
@magento run all tests |
All reactions
-
👍 2 reactions
Sorry, something went wrong.
@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
@magento run all tests |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Mohamed-Asar,
Thanks for the contribution!
I guess some of the Functional tests are failing due to the code changes. Please have a look on it.
Thanks
Sorry, something went wrong.
All reactions
-
👍 1 reaction
@engcom-Hotel Sure i will check and fix the Functional test issues |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
@magento run all tests |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
@magento run all tests |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
I fixed the functional test case which is related to this ticket, please review |
All reactions
Sorry, something went wrong.
@magento run all tests |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
Hi @Mohamed-Asar, Thanks for the collaboration & contribution! ✔️ QA PassedPreconditions:
Steps to reproduce
Before: ✖️ ![]() ![]() After: ✔️ ![]() Builds are failed. Hence, moving this PR to Extended Testing. Thanks. |
All reactions
-
🎉 1 reaction
Sorry, something went wrong.
@magento run Functional Tests B2B, Functional Tests EE |
All reactions
-
👍 1 reaction
Sorry, something went wrong.
The functional B2B and EE failures are not consistent in recent 2 builds. They are neither part of PR nor failing because of PR changes, seems to be flaky. Hence moving this PR to Merge in Progress. Functional B2B: Run 1 ![]() ![]() ![]() ![]() |
All reactions
Sorry, something went wrong.
488f68d
into
magento:2.4-develop
engcom-Hotel
Successfully merging this pull request may close these issues.
Block selection in widgets that have the same identifier
Description (*)
Used block id for widget_parameters instead of block identifier, allowing users to configure blocks with the same identifier across multiple store views.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)