-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Remove legacy compatibility code for PHP versions < 8.1 #39882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2.4-develop
Are you sure you want to change the base?
Conversation
Hi @ihor-sviziev. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- app/bootstrap.php: Language not supported
- dev/tests/static/framework/bootstrap.php: Language not supported
- dev/tests/unit/framework/bootstrap.php: Language not supported
- lib/internal/Magento/Framework/DB/DataConverter/SerializedToJson.php: Language not supported
- lib/internal/Magento/Framework/DB/Test/Unit/DB/Statement/MysqlTest.php: Language not supported
@magento run all tests |
Fix static test failures
@magento run all tests |
@magento create issue |
Description (*)
This pull request removes code that was designed to be ran on PHP <8.1.
Also, removed checks for PHP_VERSION_ID contact availability, since it's available in all PHP versions
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)
Resolved issues: