gerrit-230285-10 #2127
Open
gerrit-230285-10 #2127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creating a user class with autoblock ID fails with InvalidTitle when a namespace identifier is given in front of the ID. It works without that preleading namespaces. - This patch solves that issue and is needed handling BlockEvents in a proper way. - A more general solution with a different Autoblock class proposed by b4f0bdd may come later. - tests added Bug: T108515 Change-Id: I6de75bea5c3287cca04700b230fdec881189f32c
- derive BlockEntry from UserTargetLogEntry to get a User class with page() method - create User class directly from data['title'] instead of the superclass method in UserTargetLogEntry. Otherwise you'll get an InvalidTitle for autoblocked IDs because the User constuctor is able to handle this whereas the Page constructor isn't - use revised page() method to setup isAutoblockRemoval property. It also takes care about KeyError and returns None in that case. - tests changed Bug: T78152 Change-Id: Icaf80ed270b2fa8ffa6f2519539a47313cabc7a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.