Skip to content

improve FreeBSD support a bit (patch included) #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bit0mike opened this issue Mar 14, 2021 · 3 comments
Closed

improve FreeBSD support a bit (patch included) #549

bit0mike opened this issue Mar 14, 2021 · 3 comments

Comments

@bit0mike
Copy link

Here is a patch that fixes two calculations that currently only work on Linux so that they will also work on FreeBSD. (It does use $^O instead of uname to get the OS type, which I think is a bit more portable.) More could be done here, but this minimalist patch at least stops it from throwing errors on our FreeBSD-based Galera cluster.

mysqltuner.diff.txt

@jmrenouard
Copy link
Collaborator

Hi @bit0mike

Can you submit a pull request for this patch, please ?

https://opensource.com/article/19/7/create-pull-request-github

  • Find a project you want to contribute to
  • Fork it
  • Clone it to your local system
  • Make a new branch
  • Make your changes
  • Push it back to your repo
  • Click the Compare & pull request button
  • Click Create pull request to open a new pull request

Best regards,
Jean-Marie

@jmrenouard
Copy link
Collaborator

Hi @bit0mike

Always wanting your PR :)

BR @jmrenouard

@jmrenouard
Copy link
Collaborator

Patch included

@jmrenouard jmrenouard self-assigned this Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants