Skip to content

feat: Warn on unknown language. #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2025
Merged

Conversation

shanecelis
Copy link
Contributor

Summary

This change logs a warning when a ScriptAsset is loaded whose language is unknown. It does not alter any behavior.

WARN A script "main.p8" was added but its language is unknown. Consider adding the "p8" extension to the ScriptAssetSettings.

I've had moments where scripts load but nothing happens and it's been tricky to track down. Hopefully this'll help me and other users.

Copy link
Contributor

🐰 Bencher Report

Branchwarn-on-unknown
Testbedlinux-gha

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
component/access Lua📈 view plot
⚠️ NO THRESHOLD
3,497.90 ns
component/access Rhai📈 view plot
⚠️ NO THRESHOLD
5,261.40 ns
component/get Lua📈 view plot
⚠️ NO THRESHOLD
2,122.00 ns
component/get Rhai📈 view plot
⚠️ NO THRESHOLD
4,033.00 ns
conversions/Mut::from📈 view plot
⚠️ NO THRESHOLD
84.85 ns
conversions/Ref::from📈 view plot
⚠️ NO THRESHOLD
83.96 ns
conversions/ScriptValue::List📈 view plot
⚠️ NO THRESHOLD
265.48 ns
conversions/ScriptValue::Map📈 view plot
⚠️ NO THRESHOLD
1,224.20 ns
conversions/ScriptValue::Reference::from_into📈 view plot
⚠️ NO THRESHOLD
25.96 ns
conversions/Val::from_into📈 view plot
⚠️ NO THRESHOLD
261.04 ns
function/call 4 args Lua📈 view plot
⚠️ NO THRESHOLD
1,677.20 ns
function/call 4 args Rhai📈 view plot
⚠️ NO THRESHOLD
1,413.00 ns
function/call Lua📈 view plot
⚠️ NO THRESHOLD
235.65 ns
function/call Rhai📈 view plot
⚠️ NO THRESHOLD
446.17 ns
loading/empty Lua📈 view plot
⚠️ NO THRESHOLD
94,644.00 ns
loading/empty Rhai📈 view plot
⚠️ NO THRESHOLD
1,083,900.00 ns
math/vec mat ops Lua📈 view plot
⚠️ NO THRESHOLD
7,293.90 ns
math/vec mat ops Rhai📈 view plot
⚠️ NO THRESHOLD
6,030.30 ns
query/10 entities Lua📈 view plot
⚠️ NO THRESHOLD
18,301.00 ns
query/10 entities Rhai📈 view plot
⚠️ NO THRESHOLD
18,787.00 ns
query/100 entities Lua📈 view plot
⚠️ NO THRESHOLD
38,967.00 ns
query/100 entities Rhai📈 view plot
⚠️ NO THRESHOLD
31,566.00 ns
query/1000 entities Lua📈 view plot
⚠️ NO THRESHOLD
255,270.00 ns
query/1000 entities Rhai📈 view plot
⚠️ NO THRESHOLD
172,230.00 ns
reflection/10 Lua📈 view plot
⚠️ NO THRESHOLD
5,453.70 ns
reflection/10 Rhai📈 view plot
⚠️ NO THRESHOLD
14,593.00 ns
reflection/100 Lua📈 view plot
⚠️ NO THRESHOLD
46,364.00 ns
reflection/100 Rhai📈 view plot
⚠️ NO THRESHOLD
697,820.00 ns
resource/access Lua📈 view plot
⚠️ NO THRESHOLD
3,053.60 ns
resource/access Rhai📈 view plot
⚠️ NO THRESHOLD
4,528.30 ns
resource/get Lua📈 view plot
⚠️ NO THRESHOLD
1,784.80 ns
resource/get Rhai📈 view plot
⚠️ NO THRESHOLD
3,324.60 ns
🐰 View full continuous benchmarking report in Bencher

@makspll makspll merged commit b71380f into makspll:main May 25, 2025
14 of 19 checks passed
@github-actions github-actions bot mentioned this pull request May 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants