Skip to content

Conversation

@lwfitzgerald
Copy link
Contributor

When checking the Mongo server has come up properly, the MongoTestServer
class first creates a pymongo.MongoClient with a short timeout to avoid
waiting a long time in the failure case. After this it creates another
client with the default timeouts, but prior to this change, the initial
client is not closed.

This change explicitly closes the initial client after use.

When checking the Mongo server has come up properly, the `MongoTestServer`
class first creates a `pymongo.MongoClient` with a short timeout to avoid
waiting a long time in the failure case. After this it creates another
client with the default timeouts, but prior to this change, the initial
client is not closed.

This change explicitly closes the initial client after use.
@eeaston
Copy link
Collaborator

eeaston commented Jan 25, 2022

LGTM, thanks.

@lwfitzgerald lwfitzgerald merged commit 75e04eb into man-group:master Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants