-
Couldn't load subscription status.
- Fork 18
Add Nexus, Virtual Threads WorkerOptions to the worker-options map #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nexus, Virtual Threads WorkerOptions to the worker-options map #80
Conversation
also aligns markdown table Signed-off-by: Felipe Cortez <[email protected]>
be068fa to
0a173c5
Compare
|
Looks reasonable to me. Please add tests to: https://github.com/manetu/temporal-clojure-sdk/blob/master/test/temporal/test/vthreads.clj#L30 |
I should have qualified this as "where reasonable". For instance, it's probably pretty easy to add tests for activity threads, but not so much for poller threads. Use your judgment and get the most coverage possible. |
Sure, I'm always open to ways to improve things, including the documentation. Please do any such rearrangement as either a separate commit or PR, so it's easier to track consequential changes from formatting/presentation. |
Signed-off-by: Felipe Cortez <[email protected]>
Signed-off-by: Felipe Cortez <[email protected]>
13719b0 to
806e255
Compare
added some tests. let me know what you think of the approach |
done in a separate commit. thanks! |
Signed-off-by: Felipe Cortez <[email protected]>
806e255 to
f3fabaa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, ty!
...also aligns the markdown table in the docstring.