Skip to content

Conversation

@FelipeCortez
Copy link
Contributor

@FelipeCortez FelipeCortez commented Sep 16, 2025

...also aligns the markdown table in the docstring.

also aligns markdown table

Signed-off-by: Felipe Cortez <[email protected]>
@FelipeCortez FelipeCortez force-pushed the add-missing-worker-options branch from be068fa to 0a173c5 Compare September 16, 2025 23:33
@ghaskins
Copy link
Contributor

@ghaskins
Copy link
Contributor

Please add tests

I should have qualified this as "where reasonable". For instance, it's probably pretty easy to add tests for activity threads, but not so much for poller threads. Use your judgment and get the most coverage possible.

@ghaskins
Copy link
Contributor

Should we sort the table and map alphabetically?

Sure, I'm always open to ways to improve things, including the documentation. Please do any such rearrangement as either a separate commit or PR, so it's easier to track consequential changes from formatting/presentation.

@FelipeCortez FelipeCortez force-pushed the add-missing-worker-options branch from 13719b0 to 806e255 Compare September 19, 2025 19:13
@FelipeCortez
Copy link
Contributor Author

Please add tests

I should have qualified this as "where reasonable". For instance, it's probably pretty easy to add tests for activity threads, but not so much for poller threads. Use your judgment and get the most coverage possible.

added some tests. let me know what you think of the approach

@FelipeCortez
Copy link
Contributor Author

Should we sort the table and map alphabetically?

Sure, I'm always open to ways to improve things, including the documentation. Please do any such rearrangement as either a separate commit or PR, so it's easier to track consequential changes from formatting/presentation.

done in a separate commit. thanks!

@FelipeCortez FelipeCortez force-pushed the add-missing-worker-options branch from 806e255 to f3fabaa Compare September 19, 2025 23:25
Copy link
Contributor

@ghaskins ghaskins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, ty!

@ghaskins ghaskins merged commit 324a6ad into manetu:master Sep 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants