Small fix for inheriting class attributes from select on the ul elements that are generated at the bottom of the body element #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small fix for inheriting class attributes from select on the ul elements . It seems that this code : for (var i in classes) was causing troubles when i have in my javascript a function that is extending the Array.prototype and was appending those functions to the class attribute of the ul elements of the selectBox plugin. The problem was the scope of the variable i. Changed that with this : for (var i = 0; i < classes.length; i++) and now everything looks nice
Small fix for inheriting class attributes from select on the ul elements . It seems that this code : for (var i in classes) was causing troubles when i have in my javascript a function that is extending the Array.prototype and was appending those functions to the class attribute of the ul elements of the selectBox plugin. The problem was the scope of the variable i. Changed that with this : for (var i = 0; i < classes.length; i++) and now everything looks nice
|
@bogdanRada, can you port this to the newest version? |
|
i am not sure i understand , can you please explain? |
|
Well, your commit isn't mergeable since the line you've changed has been changed since then: for (var i in classes) {
options.addClass(classes[i] + '-selectBox-dropdown-menu');
}So if you'd create another pull request that is based on the last version I can just merge it without hassle. :) |
This was referenced Nov 12, 2013
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for inheriting class attributes from select on the ul elements . It seems that this code : for (var i in classes) was causing troubles when i have in my javascript a function that is extending the Array.prototype and was appending those functions to the class attribute of the ul elements of the selectBox plugin. The problem was the scope of the variable i. Changed that with this :
for (var i = 0; i < classes.length; i++) and now everything looks nice