Fix tripcolor with shading='faceted' #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case `edgecolors` is mistakenly set to a tuple `'k',` such that the following `ec.lower()` statement will fail with an `AttributeError`.
|
@cgohlke : Would it be hard to put together a quick test of this? I think it would be beneficial even though the code path you are fixing is deprecated. Additionally, I suspect we will want to have this bug fixed in 1.2. |
|
Basemap's ploticos.py failed, but this has now been fixed. Not sure if it's worth writing a test for a deprecated feature... |
|
@cgohlke It looks like the Travis test failures are old ones that were fixed by one of Mike's changes. Do you consider this ready to merge? |
dmcdougall
added a commit
that referenced
this pull request
Sep 30, 2012
Fix tripcolor with shading='faceted'
|
Cherry-picked into v1.2.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case
edgecolorsis mistakenly set to a tuple'k',such that the followingec.lower()statement will fail with anAttributeError.