Skip to content

Conversation

stefanceriu
Copy link
Member

This PR add a new public static method on the base-sdk's Room that allows computing room display names with much of the same logic as real rooms but from discrete values.

Copy link

codspeed-hq bot commented Oct 6, 2025

CodSpeed Performance Report

Merging #5752 will not alter performance

Comparing stefan/spaceDisplayNames (a420a81) with main (7fbc414)

Summary

✅ 50 untouched

@stefanceriu stefanceriu force-pushed the stefan/spaceDisplayNames branch from f30f9b6 to a420a81 Compare October 6, 2025 12:49
@stefanceriu stefanceriu requested a review from poljar October 6, 2025 12:58
@stefanceriu stefanceriu marked this pull request as ready for review October 6, 2025 13:00
@stefanceriu stefanceriu requested a review from a team as a code owner October 6, 2025 13:00
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 98.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.43%. Comparing base (d01a28c) to head (a420a81).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/spaces/room.rs 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5752   +/-   ##
=======================================
  Coverage   88.43%   88.43%           
=======================================
  Files         360      360           
  Lines       99624    99712   +88     
  Branches    99624    99712   +88     
=======================================
+ Hits        88103    88185   +82     
- Misses       7393     7398    +5     
- Partials     4128     4129    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant