-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update to NodeJS 8, Angular 6, electron 2.0.2, RxJS 6.1 #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I am not a PR approver on this project, just a user. I wanted to give this PR a spin since it puts Angular 6 + Electron 2 together. Everything appears to be working with this PR, except that when I ran Not a lot information or clues to debug on from this error and I expect there is something out of date or missing on my computer, but wanted to mention it here. |
|
@leifwells Nice catch :) I found the root cause is the warning messages i mentioned in above. Now, added |
|
I can confirm that these updates have resolved my issue mentioned above. |
|
Hi, Great works ! |
|
@maximegris Thanks :) I fix the conflicts! |
|
Done ! |
Changes
ng update @angular/clicommand two times)tslint.json, import all members from 'rxjs'hooks, usefileReplacementslogic inangular.jsonscriptswith--parameter patterns.Tests
npm run ng:serveworks!npm run buildworks!npm run testworks!Since Angular 6 supports webpack 4 without node-js built-ins (angular/angular-cli#9827 (comment)),
ng serveshows some warning messages.But, with electron serving, it works well :)