fix: actually test fix for local port number in /ip response
#213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Playing with fire, auto-merging again) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 10 10
Lines 2244 2244
=======================================
Hits 2121 2121
Misses 86 86
Partials 37 37 🚀 New features to boost your workflow:
|
This was referenced Jun 11, 2025
mccutchen
added a commit
that referenced
this pull request
Jun 11, 2025
Realized that the test added in #213 had a couple of small-ish issues: - Missing `t.Parallel()` call, unnecessarily slowing down overall test suite - No need to spin up new ephemeral test server, prefer the existing shared one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugh, forgot I had auto-merge turned on for #212, so it went in before I could push a test.