Improve scrolling behavior in edit preset modal #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns are accessible without scrolling
FreesoSaiFared
pushed a commit
to FreesoSaiFared/SwarmUI
that referenced
this pull request
Oct 22, 2025
* Preset modal now only scrolls the body so title and save/cancel buttons are accessible without scrolling * format fix --------- Co-authored-by: Alex "mcmonkey" Goodwin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the modal is several pages long and requires scrolling all the way to the bottom to reach the SAVE/CANCEL buttons. This is painful if you are on a device that does not have a scroll gesture (because the scrollbar is also thin and if you try to grab it and miss you almost always inadvertently cancel the modal when your miss lands outside the window).
This commit makes the header and footer of the modal sticky and only the body of the modal scrolls. Thus the SAVE/CANCEL buttons are always available.
In theory this change could be applied globally to all modals. But I limited the CSS change to just the preset modal to avoid tracking down every usage and ensuring there were no issues created by the change.