Provide more descriptive error messages when raising exceptions

[mcls]

Before this change the MessageBird::ErrorException always return the
same message in a stacktrace "MessageBird::ErrorException". Now it's
more descriptive and includes the error descriptions received from the
JSON payload.

This makes it a bit easier to debug when things go wrong.

[marcelcorso]

thank you @mcls. This looks like a great improvement.

I'm sorry but my ruby is very rusty. Can you maybe show us how did errors look before and how did they look after your PR?

[mcls]

Hi Marco, The error message was not being set by the custom MessageBird::ErrorException, so before this change they defaulted to the class name: "MessageBird::ErrorException". You can see the results of the change in the `raise_error` part of the changes I made to error_spec.rb (the second argument of raise_error tests the message contents – see related rspec docs <https://relishapp.com/rspec/rspec-expectations/docs/built-in-matchers/raise-error-matcher#match-class-+-message-with-string> .) Kind regards, Maarten

…

On Tue, May 18, 2021 at 10:58 AM marcel corso gonzalez < ***@***.***> wrote: thank you @mcls <https://github.com/mcls>. This looks like a great improvement. I'm sorry but my ruby is very rusty. Can you maybe show us how did errors look before and how did they look after your PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFOP3WWRZXCIAERG5PWCOLTOIT2VANCNFSM45B7HLAQ> .

[marcelcorso]

ah that's clear @mcls! This will improve the user experience. Very nice.

I had an idea: What do you think about instead defining a message method we override the to_s method?

[mcls]

No strong opinion. I picked "message" to conform to the StandardError interface, but later on realized "MessageBird::Error" isn't actually an exception type (subclasses MessageBird::Base). I'll update it later today. (or feel free to change it if you want)

…

On Tue, May 18, 2021 at 11:28 AM marcel corso gonzalez < ***@***.***> wrote: ah that's clear @mcls <https://github.com/mcls>! This will improve the user experience. Very nice. I had an idea: What do you think about instead defining a message method we override the to_s method? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#59 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFOP3XIA3SWKL5B5OHCR5DTOIXKLANCNFSM45B7HLAQ> .

[marcelcorso]

oh the standard error interface looks better. ok. So I think message is ok. Let's leave it like this.
thanks again!