Adds support to Verify emails, fixes verify_delete method

[gabrielso]

1. Adds support to Verify emails
   Added the VerifyEmailMessage entity
   Adds example of Verify email

2. Sets version 3.0.0-rc.1

3. Fixes verify_delete
   The client tries to instantiate a Verify object from the delete request but the response is empty.
   Response body is nil and doesn't respond to .empty?.
   Sending the request directly instead as other *_delete methods.

[jalerson]

Added a few comments and questions 👍

[jalerson]

Isn't a breaking change? Why it's necessary?

[gabrielso]

Hey @jalerson, the gem generates the attribute names based on the response from the API, and it converts camelCase to snake_case.

The response from the server contains the validUntilDatetime key, therefore the valid_until_date_time attribute breaks.

It is a breaking change that fixes a broken gem, and this is a major release as well, so I think it fits.

[jalerson]

This MR is only introducing new features to the gem, which is a minor upgrade. Why we're doing a major upgrade here?

[gabrielso]

See #62 (comment)

[jalerson]

I understand if you want to keep the test structure consistent with the other tests, however, rspec is such a powerful testing framework to write expressive tests, so I'd recommend:

• use describe to describe features
• use context to describe the feature in different situations/contexts
• use it to specify expectations (one it per expect)

For example:

describe 'Verify an email OTP' do
  context 'using an existing OTP' do
    ...

    it 'has the ID verify-id' do
      expect(verify.id).to eq 'verify-id'
    end

    it 'has the verified status' do
      expect(verify.status).to eq 'verified'
    end
  end

  context 'using a non-existing OTP' do
    it 'raises an error' do
      expect { @client.verify('verify-id') }.to raise_error(MessageBird::ErrorException)
    end
  end

  context "<insert here any other scenario>" do
    ...
  end
end

[gabrielso]

Agreed, too late 😆 .

For the topmost describe block I usually prefer to use the class I'm testing, it gives me an instance of the class in the subject variable already to be used in the examples, and I can access it in some magic ways:

describe Array do
  context "new instances" do
    it "should be empty" do
      expect(subject).to be_empty
    end
    # or magically
    it { should be_empty }
    # or
    it { is_expected.to be_empty }
  end
end

[jalerson]

Just found it's too late for my review 😅