Skip to content

Fix conversations client #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 5, 2022
Merged

Fix conversations client #70

merged 5 commits into from
Apr 5, 2022

Conversation

jalerson
Copy link
Contributor

All HTTP requests performed by the MessageBird::ConversationClient are failing because it's using the base URL rest.messagebird.com, when it should be conversations.messagebird.com.

This PR does:

  • Fix the aforementioned bug in the MessageBird::ConversationClient by moving the method endpoint from the MessageBird module to inside the class MessageBird::ConversationClient.
  • Add tests for MessageBird::ConversationClient
  • Add tests for MessageBird::Base.map_hash_elements_to_self
  • Add .byebug_history to .gitignore
  • Fixes a bug in the function MessageBird::Base.map_hash_elements_to_self(hash) by checking if hash is nil

@Ardnived Ardnived mentioned this pull request Mar 6, 2022
Open
@marcelcorso marcelcorso merged commit d7ae2fe into messagebird:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoBuchhalter NicoBuchhalter NicoBuchhalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jalerson @NicoBuchhalter @marcelcorso