Skip to content

Reduce module size or the number of steps to avoid over-time tests #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Reduce module size or the number of steps to avoid over-time tests #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions opacus/tests/grad_sample_module_fast_gradient_clipping_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def setUp_data_sequantial(self, size, length, dim):

@given(
size=st.sampled_from([10]),
length=st.sampled_from([1, 10]),
length=st.sampled_from([5]),
dim=st.sampled_from([2]),
)
@settings(deadline=1000000)
Expand Down Expand Up @@ -192,12 +192,12 @@ def test_norm_calculation_fast_gradient_clipping(self, size, length, dim):
diff = flat_norms_normal - flat_norms_gc

logging.info(f"Max difference between (vanilla) Opacus and FGC = {max(diff)}")
msg = "Fail: Gradients from vanilla DP-SGD and from fast gradient clipping are different"
msg = "Fail: Per-sample gradient norms from vanilla DP-SGD and from fast gradient clipping are different"
assert torch.allclose(flat_norms_normal, flat_norms_gc, atol=1e-3), msg

@given(
size=st.sampled_from([10]),
length=st.sampled_from([1, 10]),
length=st.sampled_from([5]),
dim=st.sampled_from([2]),
)
@settings(deadline=1000000)
Expand Down
4 changes: 2 additions & 2 deletions opacus/tests/privacy_engine_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ def _compare_to_vanilla(
do_clip=st.booleans(),
do_noise=st.booleans(),
use_closure=st.booleans(),
max_steps=st.sampled_from([1, 4]),
max_steps=st.sampled_from([1, 3]),
)
@settings(suppress_health_check=list(HealthCheck), deadline=None)
def test_compare_to_vanilla(
Expand Down Expand Up @@ -660,7 +660,7 @@ def test_checkpoints(

@given(
noise_multiplier=st.floats(0.5, 5.0),
max_steps=st.integers(8, 10),
max_steps=st.integers(3, 5),
secure_mode=st.just(False), # TODO: enable after fixing torchcsprng build
)
@settings(suppress_health_check=list(HealthCheck), deadline=None)
Expand Down
Loading