Skip to content

Better handle push notification status. RN Upgrade. #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Better handle push notification status. RN Upgrade. #106

merged 4 commits into from
May 5, 2025

Conversation

vincentritter
Copy link
Collaborator

Hey @manton,

I've looked at push notifications and tweaked the way the app handles this now.

Push tweaks

When the app loads, it will now use the old behaviour for asking for permission instead of when you go to the Mentions screen. This fixes an issue where the Push Token for the device is not always present, hence we got incorrect states in the toggle.

In addition, it now checks the new push info endpoint to grab all devices for the given app_name and push_env — this brings back a list of devices and tokens. The app then uses this to see if it's in the list, and show the correct state accordingly.

It will still automatically register for push when first logging in as user, but then any changes are preserved.

I think it seems to work nicely. When you register or unregister it will always grab an updated list of devices.

React Native Upgrade

I've update the RN version due to build errors on Android and went from 0.73.9 to 0.74.7 — I might do further RN updates in the next releases as we are slowly getting behind.

Note that you'll have to do the usual bun install and bun pods for iOS.

Android

These changes are already ready to go for Android and we've got an internal test version that seems to work nicely.

@manton manton merged commit a5d9e7d into main May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants