-
Notifications
You must be signed in to change notification settings - Fork 5
Should we swap microformat-node for microformats-parser? #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm not familiar with the current state of this, but there is also a fork of Glenn's microformat-node in this org: https://github.com/microformats/microformat-node |
As far as I can tell, that fork has never been published to the npm Registry. So while there is a fork within the Microformats organisation it feels like it is more for historical purposes. When you install microformat-node from your standard Node/JavaScript package managers you will get the glennjones/microformat-node repo one. |
I'm confused. If the "fork has never been published" why does it get installed in a standard pkg manager? |
@btrem can you elaborate? From what I can see, But I might well be mistaken. Let me know if you see other results from your package manager! |
@Zegnat you are not mistaken; I was confused. After reading your reply (and re-reading your earlier comment), I now realize you were comparing the fork with its upstream original, and not comparing the glennjones parser with the newer microformats parser. Sorry for the noise. |
/microformats/microformats-parser-website-node/issues/4 is now resolved, with the newer node parser replacing the Glenn Jones one. This commit changes link to repo to match what the site is using.
Currently this page uses microformat-node (npm, GitHub) instead of the newer microformats-parser (npm, GitHub).
There are a couple of advantages to the newer microformats-parser even apart from just being newer. Such as using the standardised test suite and being owned by the Microformats organisation on GitHub.
I am happy to do a PR for this, but are there any reasons why we would not want to switch?
The text was updated successfully, but these errors were encountered: