Skip to content

Update application dependencies #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Update application dependencies #66

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c41d219
Lock dependency versions to match versions in Gemfile.lock
jgarber623 Apr 20, 2020
fcc4202
Conservatively update development and test dependencies
jgarber623 Apr 20, 2020
76f017f
Fix deprecation warnings
jgarber623 Apr 20, 2020
4072702
Add rubocop-rails gem
jgarber623 Apr 20, 2020
f84ef05
Fix Rails/FilePath cop warning
jgarber623 Apr 20, 2020
1fff53c
Conservatively update application dependencies
jgarber623 Apr 20, 2020
90cff66
Update factory_bot_rails and rspec-rails
jgarber623 Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add rubocop-rails gem
  • Loading branch information
@jgarber623
jgarber623 committed Apr 21, 2020
commit 4072702d7d6d447020fb5c281b21dbf5ebddf9f7
9 changes: 4 additions & 5 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
require: rubocop-rspec
require:
- rubocop-rails
- rubocop-rspec
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rails cops were removed from RuboCop in version 0.72.


AllCops:
TargetRubyVersion: 2.5
Expand All @@ -15,17 +17,14 @@ AllCops:
- '.git/**/*'

IndentationConsistency:
EnforcedStyle: 'rails'
EnforcedStyle: 'indented_internal_methods'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another change in RuboCop version 0.72.


Naming/FileName:
Exclude:
- 'Gemfile'
- 'Guardfile'
- 'Rakefile'

Rails:
Enabled: true

Metrics/CyclomaticComplexity:
Max: 15

Expand Down
3 changes: 2 additions & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ gem 'uglifier', '4.1.17'

# For codestyle guide and linting
gem 'rubocop', '~> 0.82.0', require: false
gem 'rubocop-rspec', '~> 1.38'
gem 'rubocop-rails', '~> 2.5', require: false
gem 'rubocop-rspec', '~> 1.38', require: false

# dev and testing
group :development, :test do
Expand Down
5 changes: 5 additions & 0 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,10 @@ GEM
rexml
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 2.0)
rubocop-rails (2.5.2)
activesupport
rack (>= 1.1)
rubocop (>= 0.72.0)
rubocop-rspec (1.38.1)
rubocop (>= 0.68.1)
ruby-progressbar (1.10.1)
Expand Down Expand Up @@ -270,6 +274,7 @@ DEPENDENCIES
rails-controller-testing (~> 1.0)
rspec-rails (~> 3.9)
rubocop (~> 0.82.0)
rubocop-rails (~> 2.5)
rubocop-rspec (~> 1.38)
sass-rails (= 5.0.7)
simplecov (~> 0.18.5)
Expand Down