Skip to content

Bump php version support to 5.6 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonnybarnes opened this issue Jul 18, 2016 · 14 comments · Fixed by #220
Closed

Bump php version support to 5.6 #104

jonnybarnes opened this issue Jul 18, 2016 · 14 comments · Fixed by #220
Milestone

Comments

@jonnybarnes
Copy link

Neither 5.4 or 5.5 are receiving security fixes anymore, they’ve been EOL-ed.

See https://secure.php.net/supported-versions.php

@voxpelli
Copy link
Contributor

See #101, I'm +1 on increasing it, but it causes problems with eg. some people's WordPress blogs so it was decided to support older ones for now.

@dshanske
Copy link
Member

I think you are asking the wrong question. What feature do you need that isn't supported in the earlier versions?

@gRegorLove
Copy link
Member

I'm -0.

We only bumped the Composer requirement from 5.3 to 5.4 a couple months ago with the latest release, and that was primarily for parse_url() fixes. Since the lib works fine on 5.4+, I don't see a strong reason to require higher at this point.

@aaronpk
Copy link
Member

aaronpk commented Sep 18, 2016

Agreed with the others. I don't see a reason to bump the requirement to 5.6 as long as it works in 5.4, since there are still active (mostly WordPress) sites running 5.4 and 5.5. WordPress does recommend PHP 5.6 but sadly there are still plenty of hosts that haven't upgraded yet. When this chart shows less 5.4 and 5.5 installations we can bump the requirement https://wordpress.org/about/stats/

@aaronpk aaronpk closed this as completed Sep 18, 2016
@jonnybarnes
Copy link
Author

5.2 and 5.3 have a depressingly large share :(

@gRegorLove
Copy link
Member

Re-opening. WordPress 5.2 now requires PHP 5.6.20 (announced 2019-04-01). We're pretty sure this was the only reason we kept PHP 5.4 support for so long, so will probably update minimum version to 5.6 with the next release. Any objections?

@gRegorLove gRegorLove reopened this Dec 17, 2019
@gRegorLove gRegorLove added this to the 0.4.7 milestone Dec 17, 2019
@jonnybarnes
Copy link
Author

The wordpress stats page has 12.7% of installs running on php >5.6, I’m all for bumping version support, people running older versions of php will simply get “stuck” on the last version that supports there setup

@Ryuno-Ki
Copy link

Ryuno-Ki commented Feb 4, 2020

I mean, I could be wrong, but PHP 5.6 reached EOL last year.
Are you sure, you want to support it?

@aaronpk
Copy link
Member

aaronpk commented Feb 4, 2020

We need to support pretty far back in order to support live wordpress sites. Just because a version reaches EOL doesn't mean everyone suddenly upgrades.

@Ryuno-Ki
Copy link

Ryuno-Ki commented Feb 4, 2020

I know that from the Python world.
However, not guaranteeing support for EOL versions of a runtime can spur motivation to upgrade.
Otherwise you might run into the Python2.7-problem …

@aaronpk
Copy link
Member

aaronpk commented Feb 4, 2020

Sure, but this is more about following Wordpress than making our own decision. I seriously doubt this library would be the reason someone would hold off on updating PHP.

@voxpelli
Copy link
Contributor

voxpelli commented Feb 4, 2020

Not possible to release a new major and backport any important changes to the version the WordPress plugin uses?

@aaronpk
Copy link
Member

aaronpk commented Feb 4, 2020

Possible? sure. Anyone want to volunteer to do that? 😂

@dshanske
Copy link
Member

dshanske commented Feb 5, 2020

Can I ask again what newer features you want to incorporate? Version should be bumped for that reason. Even though PHP versions hit EOL, that isn't an issue for the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants