Skip to content

Fix vevent location backcompat #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gRegorLove opened this issue Jul 31, 2018 · 2 comments
Closed

Fix vevent location backcompat #184

gRegorLove opened this issue Jul 31, 2018 · 2 comments
Milestone

Comments

@gRegorLove
Copy link
Member

From https://github.com/microformats/tests/blob/master/tests/microformats-v1/hcalendar/combining.html

<div class="vevent">
  <a class="summary url" href="http://indiewebcamp.com/2012">
    IndieWebCamp 2012
  </a>
  from <time class="dtstart">2012-06-30</time> 
  to <time class="dtend">2012-07-01</time> at 
  <span class="location vcard">
    <a class="fn org url" href="http://geoloqi.com/">Geoloqi</a>, 
    <span class="adr">
        <span class="street-address">920 SW 3rd Ave. Suite 400</span>, 
        <span class="locality">Portland</span>, 
        <abbr class="region" title="Oregon">OR</abbr>
    </span>
  </span>
</div>

Currently parses the vcard as a child instead of location property:

"items": [
    {
        "type": [
            "h-event"
        ],
        "properties": {
            "name": [
                "IndieWebCamp 2012"
            ],
            "url": [
                "http://indiewebcamp.com/2012"
            ],
            "start": [
                "2012-06-30"
            ],
            "end": [
                "2012-07-01"
            ]
        },
        "children": [
            {
                "type": [
                    "h-card"
                ],
                "properties": {
                    "name": [
                        "Geoloqi"
                    ],
                    "org": [
                        "Geoloqi"
                    ],
                    "url": [
                        "http://geoloqi.com/"
                    ],
                    "adr": [
                        {
                            "type": [
                                "h-adr"
                            ],
                            "properties": {
                                "street-address": [
                                    "920 SW 3rd Ave. Suite 400"
                                ],
                                "locality": [
                                    "Portland"
                                ],
                                "region": [
                                    "Oregon"
                                ]
                            },
                            "value": "920 SW 3rd Ave. Suite 400, \n        Portland, \n        Oregon"
                        }
                    ]
                }
            }
        ]
    }
]

I think this line needs to be changed to p-location h-card.

@gRegorLove
Copy link
Member Author

@gRegorLove gRegorLove added this to the 0.4.7 milestone Aug 25, 2018
gRegorLove added a commit to gRegorLove/php-mf2 that referenced this issue Aug 25, 2018
gRegorLove added a commit to gRegorLove/php-mf2 that referenced this issue May 7, 2020
gRegorLove added a commit to gRegorLove/php-mf2 that referenced this issue May 10, 2020
@barnabywalters barnabywalters modified the milestones: 0.5.0, 0.5.1 Feb 10, 2022
gRegorLove added a commit to gRegorLove/php-mf2 that referenced this issue Jul 8, 2022
gRegorLove added a commit to gRegorLove/php-mf2 that referenced this issue Sep 26, 2022
gRegorLove added a commit to gRegorLove/php-mf2 that referenced this issue Mar 8, 2024
@gRegorLove
Copy link
Member Author

Resolved with #234 and #241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants