Relative URL parsing code doesn’t handle protocol-relative URLs

[barnabywalters]

E.G. <a class="u-url" href="//domain.com/"> on http://example.com/page.html gets resolved to http://example.com/page.html//domain.com/

cc @aaronpk

[aaronpk]

oh dear! add a couple test cases and I'll be sure to check it out.

[barnabywalters]

As noted by @aaronpk in IRC: perhaps the fail case is only when the base url has a path — need to add another test.

Agreed, also need to find the example this was/is failing with and document+reproduce it.

[aaronpk]

Seems to be a difference between php 5.3 and 5.4. A simple example parses correctly under 5.4 but fails under 5.3

[aaronpk]

Confirmed. parse_url was fixed in PHP 5.4.7 "Fixed host recognition when scheme is omitted and a leading component separator is present." Before that, a scheme-less URL would not be parsed correctly.

[aaronpk]

My suggestion to resolve this is to require PHP 5.4 since 5.3 was declared unsupported in August 2014. http://php.net/eol.php

[jonnybarnes]

PHP5.4 is also EOL now.

[aaronpk]

ha! Well it seems safe to require a min of 5.4 then. Any objection, @barnabywalters? I would also be curious to hear from @benwerd if he thinks that would be okay.

[jonnybarnes]

Well, looking at the most recent commit there was one single test error that occurred in 5.4, if it were up to me I’d drop 5.4 support, unless someone can be bothered to fix said bug: https://travis-ci.org/indieweb/php-mf2/jobs/103192590

[aaronpk]

Just for the record, I've updated the test suite so that failure is passing now in 5.4. See https://github.com/aaronpk/php-mf2/commit/bfe4a0af9ef563c575fea2feac86e1ea120de053

I would still recommend dropping PHP 5.3 support. Known requires a minimum of 5.4 so this shouldn't be a problem for @benwerd either.

[barnabywalters]

I’m happy requiring a minimum of PHP 5.4 as of the next release. The current version of the parser works well enough for anyone forced to use PHP 5.3.

[gRegorLove]

I think this can be closed now?

[aaronpk]

Yep! Looks like we're requiring 5.4 now.