Switch to Yoast PHP Polyfill #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lewiscowles1986
commented
Jun 27, 2022
| "mf2/tests": "dev-master#e9e2b905821ba0a5b59dab1a8eaf40634ce9cd49", | ||
| "squizlabs/php_codesniffer": "^3.6.2", | ||
| "dealerdirect/phpcodesniffer-composer-installer": "^0.7", | ||
| "phpcompatibility/php-compatibility": "^9.3" |
There was a problem hiding this comment.
The indentation bothered me.
Lewiscowles1986
commented
Jun 27, 2022
| @@ -18,11 +18,11 @@ | |||
| } | |||
| }, | |||
| "require-dev": { | |||
| "phpunit/phpunit": "^5.7", | |||
There was a problem hiding this comment.
This gets removed to add yoast/phpunit-polyfills dependency.
Lewiscowles1986
commented
Jun 27, 2022
| @@ -179,7 +178,7 @@ public function testMoreDetailedPerson() { | |||
| "type": ["h-card"], | |||
| "properties": { | |||
| "photo": [ | |||
| { | |||
| { | |||
There was a problem hiding this comment.
this one-liner may be a mistake... Lets see what CI says.
Merged
Lewiscowles1986
force-pushed
the
feature/yoast-phpunit-polyfill
branch
from
95596ed to
13b5eb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #213 for history
Uses Yoast PHPUnit Polyfill, which I've personally used for 5.4 -> 8.1 compatibility previously.
Just need to see if the workflow passes.
This should unlock PHP8 / 8.1 compatibility.
It's another layer of indirection + a little bit of magic to not be coupled to the unstable API of PHPUnit.