Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, this test suite is working. However, I ran into some whitespace issues when comparing the parsed output to the expected output.
For example, test
adr/simpleproperties
indicates the (implied)name
output should be665 3rd St. Suite 207 San Francisco, CA 94107 U.S.A.
But the Mf2 parser returns
665 3rd St. \r\n Suite 207 \r\n San Francisco, \r\n CA \r\n 94107 \r\n U.S.A.
- which appears correct according to the specifications; whitespace should be preserved within the contents since it follows the DOM textContent. http://microformats.org/wiki/microformats2-parsing#parsing_for_implied_properties and chat logs with tantek's comments http://indiewebcamp.com/irc/2014-07-20#t1405898141.I also think this test suite shows some changes to be made to php-mf2, e.g. for
adr
microformats not inside anhcard
. That is a separate issue, though. :) Refer to the chat logs here: http://indiewebcamp.com/irc/2014-07-20#t1405891518Issue #50