Added failing test and fix for #57 #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated tests to avoid implied u-url, test existing class attribute, and more complex rel-bookmark.
|
I realized these tests would imply a u-url regardless of the rel-bookmark, so I moved the rel-bookmark links inside the entry-title to ensure this fix is working. I also improved the Xpath to account for more complex rel-bookmark values (h/t http://stackoverflow.com/a/9133579). |
|
@gRegorLove thanks for getting this working! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please double-check my xpath query since I'm not the greatest with xpath. Appears to be working, though, using the same test mf2py did.