Skip to content

add Github Actions workflow to run the unit and compat tests #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2021

Conversation

wnienhaus
Copy link
Collaborator

This PR fixes issue #44 .

It implements what the previous Travis CI build does, except it:

  • Runs on Ubuntu 18.04 instead of 14.04/trusty (On Ubuntu 20.04 the build of binutils-esp32ulp fails)
  • Shallow clones repos (--depth 1) to save on build time
  • Only clones and builds submodules actually required for building the Unix build of MicroPython (instead of doing a full --recursive clone) to save on build time

This change also removes the .travis.yml file, which is no longer needed.

This implements what the current Travis CI build does, except:
* Runs on Ubuntu 18.04 instead of 14.04 (trusty)
  (On Ubuntu 20.04 the build of binutils-esp32ulp fails)
* Shallow clones repos (--depth 1) to save on build time
* Only clones and builds submodules actually required for building
  the Unix build of MicroPython (instead of doing a full --recursive
  clone) to save on build time

This change also removes the .travis.yml file, which is no
longer needed.
@wnienhaus
Copy link
Collaborator Author

It appears Github Actions does not run when the workflow file is yet-to-be-merged. But you can see the build succeed on my fork of the repo: https://github.com/wnienhaus/py-esp32-ulp/actions/runs/1087314522 (you can compare the commit id to confirm the build was for the same commit as this PR includes: 7ea24ff)

@wnienhaus
Copy link
Collaborator Author

..actually I found this in the docs of Github Actions, which seems to explain why the workflow doesnt run:

When a first-time contributor submits a pull request to a public repository, a maintainer with write access may need to approve running workflows on the pull request. For more information, see "Approving workflow runs from public forks."

Copy link
Collaborator

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, let's see if we can run it...

@ThomasWaldmann ThomasWaldmann merged commit bb7f3a7 into micropython:master Aug 1, 2021
@ThomasWaldmann
Copy link
Collaborator

ThomasWaldmann commented Aug 1, 2021

as long as the workflow file is not yet present, it won't run one in the PR.

thus i just merged and now we need another PR to have it running.

Maybe do some dummy commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants