umqtt subscribe to topic with 23 bytes fails

[DDDanny]

Hi,
I can't subscribe to topic longer than 122 bytes. Publishing works fine!
I kindly ask you to verify and hopefully fix it
Thanks a lot
Danny

OK - working:

#122 bytes
mqtt.subscribe(b"/234567890/234567890/234567890/234567890/234567890/234567890/234567890/234567890/234567890/234567890/234567890/234567890/2") 

but one more character:

#123 bytes
mqtt.subscribe(b"/234567890/234567890/234567890/234567890/234567890/234567890/234567890/234567890/234567890/234567890/234567890/234567890/23") 

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "test.py", line 169, in <module>
  File "umqtt_simple.py", line 154, in subscribe
  File "umqtt_simple.py", line 173, in wait_msg
OSError: -1

this might be related to #163 which also deals with 127 bytes

it might be related to

micropython-lib/umqtt.simple/umqtt/simple.py

Line 148 in f20d89c

struct.pack_into("!BH", pkt, 1, 2 + 2 + len(topic) + 1, self.pid)

as this is hitting the 128...

[dpgeorge]

It looks like the subscribe method needs to handle variable length encoding of the payload size, in the same way that connect and publish do.

[jonnor]

This appears ot have been fixed in the linked MRs/commits. Proposing to close this issue.

[projectgus]

Looks like the author's PR was closed last year without merging, so I think this may still be an issue.

[mbuehler1990]

I had the same issue and @SpotlightKid fix worked for me. Sad that the PR is not merged