Skip to content

There were no check_msg(self) function in umqtt.robust/umqtt/robust.py #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Actpohomoc
Copy link

No description provided.

@Actpohomoc Actpohomoc changed the title There were no check_msg(self) function There were no check_msg(self) function in umqtt.robust/umqtt/robust.py Nov 9, 2016
@pfalcon
Copy link
Contributor

pfalcon commented Nov 9, 2016

@pfalcon
Copy link
Contributor

pfalcon commented Nov 9, 2016

Also, I'm not exactly sure my intention with check_msg() was like that. The semantics of check_msg() is that it should complete immediately. Adding self.reconnect() to it makes it not such. I'm afraid, I have to reject this patch for now - if you use ckeck_msg(), please move catching exception and .reconnect() login into your app. And then you can handle it any way you like, and you let to do everyone else to do the same, in particular guarantee that check_msg() return immediately and can be used in main loops doing something else (otherwise, check_msg() may block your main loop indefinitely).

@Actpohomoc
Copy link
Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants