Supported socket timeout #237
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pfalcon ping |
|
Not all MicroPython ports support socket.settimeout (notably the unix port). So this won't work. |
|
Maybe we can reflect this in docs/comments? I'll change the code so that the .settimeout invokes only if the value is passed. It's better to allow this at least on some platforms rather than force the lib's modifications, isn't it? |
|
@dpgeorge, Hey, what's the status? |
|
push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really need timeout, please merge.
I'm not sure that the behavior does not change, but maybe it's a good idea to set the default timeout to a kind of 30 seconds