Skip to content

Dxxb/ucontextlib #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Dxxb/ucontextlib #50

wants to merge 2 commits into from

Conversation

dxxb
Copy link
Contributor

@dxxb dxxb commented Oct 21, 2015

Minimal module spin off from existing contextlib as discussed in Issue #49.
Test were broken because of changes to unittest.run_class() so I moved to invoking unittest.main().
Not sure what to change the description in metadata and doctext to.

@pfalcon
Copy link
Contributor

pfalcon commented Oct 22, 2015

I'll merge this as is, but preference should be on making as little as possible changes to CPython tests (by byte size of the resulting diff). By this logic, ContextManagerTestCase should not have been removed (regardless whether it's duplicated in ucontextlib module).

@pfalcon
Copy link
Contributor

pfalcon commented Oct 22, 2015

You also apparently don't use make_metadata.py utility, but edit setup.py manually, which leads to mistakes. Please follow https://github.com/micropython/micropython-lib/wiki/ContributorGuidelines

@dxxb
Copy link
Contributor Author

dxxb commented Oct 22, 2015

Hi, I thought duplicating the test case would lead to PR rejection. I can fix that and use make_metadata.py to generate setup.py

@pfalcon
Copy link
Contributor

pfalcon commented Oct 22, 2015

Merged with number of metadata changes.

@dxxb
Copy link
Contributor Author

dxxb commented Oct 22, 2015

Thanks

@pfalcon
Copy link
Contributor

pfalcon commented Oct 22, 2015

Hi, I thought duplicating the test case would lead to PR rejection.

This matter also covered in https://github.com/micropython/micropython-lib/wiki/ContributorGuidelines . And those guidelines are not arbitrary, but rooted in the fact that maintaining a project with dozen of individual components isn't easy, moreover if majority of components come from other projects.

I can fix that and use make_metadata.py to generate setup.py

Well, I don't want to block on this, but please follow those guidelines in the future ;-)

@pfalcon pfalcon closed this Oct 22, 2015
@dxxb
Copy link
Contributor Author

dxxb commented Oct 23, 2015

Thank you. Point taken! :)

@dxxb dxxb deleted the dxxb/ucontextlib branch October 23, 2015 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants