Skip to content

contextlib: port ExitStack from CPython 3.4 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2015

Conversation

dxxb
Copy link
Contributor

@dxxb dxxb commented Oct 31, 2015

See discussion in #49

@dxxb
Copy link
Contributor Author

dxxb commented Oct 31, 2015

I am not sure I like the fact I changed instances of of assertIsNone() to assert is None. I'm happy to add assertIsNone() to unittest and get back to this.

@pfalcon
Copy link
Contributor

pfalcon commented Oct 31, 2015

I am not sure I like the fact I changed instances of of assertIsNone() to assert is None. I'm happy to add assertIsNone() to unittest and get back to this.

Sure, feel free to, unittest is not size-critical (it's just big mess o'code from my point of view, so I didn't even try to port it, instead was adding method on as-needed basis, other contributed a bunch too).

@dxxb
Copy link
Contributor Author

dxxb commented Nov 1, 2015

I'd rather use 'assert x is None' directly but it would result in more line changes when porting tests from CPython. I have created #52 and rebased this PR on it.

@dxxb
Copy link
Contributor Author

dxxb commented Nov 1, 2015

Hi @pfalcon, this is ready to be reviewed.

@dxxb
Copy link
Contributor Author

dxxb commented Nov 3, 2015

PR updated. Prefixed incompatible test names with underscore.

@pfalcon pfalcon merged commit 184ea31 into micropython:master Nov 3, 2015
@pfalcon
Copy link
Contributor

pfalcon commented Nov 3, 2015

Merged, thanks.

@dxxb
Copy link
Contributor Author

dxxb commented Nov 3, 2015

Apologies for the oversight and thank you.

@dxxb dxxb deleted the dxxb/exitstack branch October 27, 2016 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants