-
Notifications
You must be signed in to change notification settings - Fork 1k
contextlib: port ExitStack from CPython 3.4 #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am not sure I like the fact I changed instances of of assertIsNone() to assert is None. I'm happy to add assertIsNone() to unittest and get back to this. |
Sure, feel free to, unittest is not size-critical (it's just big mess o'code from my point of view, so I didn't even try to port it, instead was adding method on as-needed basis, other contributed a bunch too). |
I'd rather use 'assert x is None' directly but it would result in more line changes when porting tests from CPython. I have created #52 and rebased this PR on it. |
Hi @pfalcon, this is ready to be reviewed. |
PR updated. Prefixed incompatible test names with underscore. |
Merged, thanks. |
Apologies for the oversight and thank you. |
See discussion in #49