ExecutionTest Programmable Sample Offsets #4285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A texture containing an encoded value representing the X,Y location is used to retrieve values at various samples using the 8 methods that newly allow programmable values. Each result is compared to what is expected based on the given coords and offsets.
|
✅ Build DirectXShaderCompiler 1.0.1274 completed (commit 8e37f89a63 by @pow2clk) |
jholewinski
reviewed
Feb 23, 2022
jholewinski
reviewed
Feb 23, 2022
jholewinski
reviewed
Feb 23, 2022
jholewinski
reviewed
Feb 23, 2022
jholewinski
reviewed
Feb 23, 2022
PS shaders weren't running and had some bugs removed code belonging to a different commit better ifdef shader model version better document magic numbers
tex3d
reviewed
Feb 25, 2022
|
✅ Build DirectXShaderCompiler 1.0.1303 completed (commit f536f818ec by @pow2clk) |
tex3d
reviewed
Feb 25, 2022
tex3d
reviewed
Feb 25, 2022
tex3d
reviewed
Feb 25, 2022
|
✅ Build DirectXShaderCompiler 1.0.1304 completed (commit 92584bd23f by @pow2clk) |
|
✅ Build DirectXShaderCompiler 1.0.1308 completed (commit 25315aeaaa by @pow2clk) |
Tex added a bunch of version and optional support variants This corrects the mesh shaders that were indexing incorrectly and also had too few threads to properly set up the triangles Probably a few other things I've left out :p
tex3d
reviewed
Feb 25, 2022
| if (!CreateDevice(&pDevice, sm, /*skipUnsupported*/false)) { | ||
| LogCommentFmt(L"Device does not support shader model 6.%1u", | ||
| ((UINT)sm & 0x0f)); | ||
| continue; |
There was a problem hiding this comment.
Oh, should have made this break; instead of continue; so it doesn't keep trying higher shader models.
if it doesn't have 6.x, it's not going to have 6.y
|
✅ Build DirectXShaderCompiler 1.0.1312 completed (commit 82b7488bde by @pow2clk) |
|
✅ Build DirectXShaderCompiler 1.0.1313 completed (commit 44d216385a by @pow2clk) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A texture containing an encoded value representing the X,Y location is
used to retrieve values at various samples using the 8 methods that
newly allow programmable values. Each result is compared to what is
expected based on the given coords and offsets.